CMDCT-4226 - sets up deploy-prerequisites to create resources needed in AWS account #15025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peoplespete
changed the title
peoplespete
requested review from
BearHanded,
braxex,
jessabean and
benmartin-coforma
as code owners
JonHolman
reviewed
Jan 7, 2025
deployment/prerequisites.ts
Outdated
| import { | ||
| aws_apigateway as apigateway, | ||
| aws_iam as iam, | ||
| } from "aws-cdk-lib"; |
There was a problem hiding this comment.
Suggested change
| } from "aws-cdk-lib"; | |
| App, | |
| DefaultStackSynthesizer, | |
| Stack, | |
| StackProps, | |
| Tags, | |
| } from "aws-cdk-lib"; |
There was a problem hiding this comment.
Much better thanks!
There was a problem hiding this comment.
I was trying to suggest a change, but then I messed up the formatting. I ended up making a commit.
JonHolman
reviewed
Jan 7, 2025
JonHolman
approved these changes
Jan 7, 2025
peoplespete
added a commit
that referenced
this pull request
Jan 31, 2025
…in AWS account (#15025) Co-authored-by: Jon Holman <[email protected]>
JonHolman
added a commit
that referenced
this pull request
Jan 31, 2025
…in AWS account (#15025) Co-authored-by: Jon Holman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite resources instead of being created in each stack or each !isDev stack will exist in a single stack that is created in each AWS account.
Related ticket(s)
CMDCT-4226
How to test
You can check out the existing 4226 stack and it's cloudfront url:
https://d2obsaoedfxcpv.cloudfront.net/
Unfortunately seds-prerequisite stack and jon-cdk stack can't both exist at the same time so let me know if you want to see seds-prerequisite in action and I can temporarily destroy jon-cdk stack (again, I already did this a couple times to test).
Notes
NA
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod